Fix inject_debug_resources target#44238
Merged
Merged
Conversation
jkoritzinsky
approved these changes
Nov 4, 2020
jkoritzinsky
left a comment
jkoritzinsky
left a comment
Member
There was a problem hiding this comment.
I hate batch scripts so much
mikem8361
approved these changes
Nov 4, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44232
Turns out the CMake custom command used to inject the DAC table ends up in a generated wrapper BAT script. dotnet.cmd seems to not be executed using CALL inside the script and then the generation exits the script and ends up exiting the custom target before it gets to inject them. Instead, call CMD to execute the script.