Skip to content

Workaround xunit bug for disabling FileStreamStandaloneConformanceTests #44295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Nov 5, 2020
Merged

Workaround xunit bug for disabling FileStreamStandaloneConformanceTests #44295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/Tests/System/IO/StreamConformanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
namespace System.IO.Tests
{
/// <summary>Base class providing tests for any Stream-derived type.</summary>
[ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsNotBrowser))] // lots of operations aren't supported on browser
[PlatformSpecific(~TestPlatforms.Browser)] // lots of operations aren't supported on browser
public abstract class StreamConformanceTests : FileCleanupTestBase
{
/// <summary>Gets the name of the byte[] argument to Read/Write methods.</summary>
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,15 @@ public class BufferedSyncFileStreamStandaloneConformanceTests : FileStreamStanda
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/34583", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[PlatformSpecific(~TestPlatforms.Browser)] // copied from base class due to https://github.com/xunit/xunit/issues/2186
public class UnbufferedAsyncFileStreamStandaloneConformanceTests : FileStreamStandaloneConformanceTests
{
protected override FileOptions Options => FileOptions.Asynchronous;
protected override int BufferSize => 1;
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/34583", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[PlatformSpecific(~TestPlatforms.Browser)] // copied from base class due to https://github.com/xunit/xunit/issues/2186
public class BufferedAsyncFileStreamStandaloneConformanceTests : FileStreamStandaloneConformanceTests
{
protected override FileOptions Options => FileOptions.Asynchronous;
Expand Down