Skip to content

Signing cleanup - #44658

Merged
jkoritzinsky merged 9 commits into
dotnet:masterfrom
jkoritzinsky:signing-cleanup
Nov 17, 2020
Merged

Signing cleanup#44658
jkoritzinsky merged 9 commits into
dotnet:masterfrom
jkoritzinsky:signing-cleanup

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Now that #38457 is merged in, there's more cleanup we can do of the signing infrastructure in the repo.

This PR moves the CrossOS DAC signing to be done in the CrossDac Pack job. As a result, we can remove the signing at build time and remove the signing during prepare-artifacts.

I also renamed UnsignedArtifacts->IntermediateArtifacts because some of the artifacts are signed and the final artifacts after prepare-artifacts are still unsigned now that we only support post build signing.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=885893&view=results

…ild. Remove old incremental signing infrastructure since we no longer use it.
…are now signed and our final artifacts are unsigned.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
@ghost

ghost commented Nov 13, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Details

Issue Details
Description:

Now that #38457 is merged in, there's more cleanup we can do of the signing infrastructure in the repo.

This PR moves the CrossOS DAC signing to be done in the CrossDac Pack job. As a result, we can remove the signing at build time and remove the signing during prepare-artifacts.

I also renamed UnsignedArtifacts->IntermediateArtifacts because some of the artifacts are signed and the final artifacts after prepare-artifacts are still unsigned now that we only support post build signing.

Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=885893&view=results

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@jkoritzinsky

Copy link
Copy Markdown
Member Author

Looks like I've got a little more work to do relating to the hosting packages (they still use the old tooling) before I can do this.

…through the old Microsoft.DotNet.Build.Tasks.SharedFramework tooling.
Comment thread src/installer/pkg/projects/host-packages.proj Outdated
@jkoritzinsky

jkoritzinsky commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

@jkoritzinsky

Copy link
Copy Markdown
Member Author

Looks like our build are getting NuGet rate limited again (at least my PR is).

@ViktorHofer

Copy link
Copy Markdown
Member

#44700

@jkoritzinsky

Copy link
Copy Markdown
Member Author

The official build passed. I'll try to get a passing build here as well.

@ghost

ghost commented Nov 17, 2020

Copy link
Copy Markdown

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jkoritzinsky

Copy link
Copy Markdown
Member Author

Errors are the usual errors we've been seeing with the Android runtime tests. Since this PR only affects CoreCLR and installer and the official build passed, I'm going to merge this in.

@jkoritzinsky
jkoritzinsky merged commit d2fc747 into dotnet:master Nov 17, 2020
@jkoritzinsky
jkoritzinsky deleted the signing-cleanup branch November 17, 2020 20:30
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants