Skip to content

Reenable Mono Windows runtime build in runtime-official.yml - #45376

Merged
akoeplinger merged 1 commit into
dotnet:masterfrom
akoeplinger:reenable-mono-windows
Dec 1, 2020
Merged

Reenable Mono Windows runtime build in runtime-official.yml#45376
akoeplinger merged 1 commit into
dotnet:masterfrom
akoeplinger:reenable-mono-windows

Conversation

@akoeplinger

Copy link
Copy Markdown
Member

The binary now includes the proper version header.

Fixes #37503

Test official build passed: https://dev.azure.com/dnceng/internal/_build/results?buildId=903046&view=results

The binary now includes the proper version header.

Fixes dotnet#37503
@ghost

ghost commented Nov 30, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

The binary now includes the proper version header.

Fixes #37503

Test official build passed: https://dev.azure.com/dnceng/internal/_build/results?buildId=903046&view=results

Author: akoeplinger
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@safern

safern commented Dec 1, 2020

Copy link
Copy Markdown
Member

What about other windows?

@akoeplinger
akoeplinger merged commit 49f7896 into dotnet:master Dec 1, 2020
@akoeplinger
akoeplinger deleted the reenable-mono-windows branch December 1, 2020 11:29
@akoeplinger

Copy link
Copy Markdown
Member Author

What about other windows?

You mean arm and arm64 windows? I think that's not a focus for Mono right now.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mono not producing native binaries with version header in Windows

2 participants