Fix PlaintextStreamFilter for sync requests#45388
Merged
Merged
Conversation
As with ConnectCallback, make it usable for sync requests. Also: - Consolidate blocking to the sync entry point where possible. - Remove unnecessary async arguments - Fix XxAsync naming on several methods
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAs with ConnectCallback, make it usable for sync requests. Also:
Follow-up to #45300
|
geoffkizer
reviewed
Nov 30, 2020
geoffkizer
reviewed
Nov 30, 2020
geoffkizer
approved these changes
Nov 30, 2020
geoffkizer
left a comment
geoffkizer
left a comment
Contributor
There was a problem hiding this comment.
One small issue above, otherwise LGTM
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with ConnectCallback, make it usable for sync requests. Also:
Follow-up to #45300
cc: @geoffkizer, @ManickaP