WinHttpHandler: fix double -> uint conversions for ARM64#45480
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAccording to the Explicit numeric conversions section of the C# specification, the unchecked case of a
Looks like we do not handle the Fixes #45249 Note: /cc @EgorBo @tannergooding if interested.
|
CarnaViire
left a comment
There was a problem hiding this comment.
A tiny nit, otherwise LGTM
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
Test failures are unrelated. |
|
Failures are known and unrelated. Merging to unblock CI. |
|
Failures are:
(was looking at it while Santi merged the PR) |
@antonfirsov even if test failures are unrelated, in future please search for existing issues or create them and link to the affected build so that the failures are refcounted. |
According to the Explicit numeric conversions section of the C# specification, the unchecked case of a
double->uintcast goes as following:Looks like we do not handle the
Timeout.InfiniteTimeSpan.TotalMilliseconds == -1.0case correctly forReceiveDataTimeoutandTcpKeepAlive*, the latter resulting in test failures on ARM64 machines.Fixes #45249
Note:
The failing
Libraries Test Run release coreclr windows arm64 Releasejob does not get executed on PR-s, only onrefs/heads/master, which means there is no way for me to validate the change before merging it. (Unless someone can suggest a way to access an ARM64 windows machine.)/cc @EgorBo @tannergooding if interested.