Skip to content

[release/5.0] Redirect default install location in test to avoid using machine-wide install - #45525

Merged
AaronRobinsonMSFT merged 1 commit into
release/5.0from
backport/pr-45500-to-release/5.0
Dec 10, 2020
Merged

[release/5.0] Redirect default install location in test to avoid using machine-wide install#45525
AaronRobinsonMSFT merged 1 commit into
release/5.0from
backport/pr-45500-to-release/5.0

Conversation

@github-actions

@github-actions github-actions Bot commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

Backport of #45500 to release/5.0
Issue: #45510

/cc @elinor-fung

Customer Impact

None. This is a test fix to address a test failure that will occur on Windows machines with a global install of .NET 5.

Testing

Test passes in CI builds (Windows with VS16.8, where it was failing without this change).

Risk

Low.

@ghost

ghost commented Dec 3, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #45500 to release/5.0

/cc @elinor-fung

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@ghost

ghost commented Dec 3, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #45500 to release/5.0

/cc @elinor-fung

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Host

Milestone: -

@jeffschwMSFT jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Given this is test only we can use tell mode. Please work with @mmitche on when a good time to merge would be.

@mmitche

mmitche commented Dec 3, 2020

Copy link
Copy Markdown
Member

Approved. Given this is test only we can use tell mode. Please work with @mmitche on when a good time to merge would be.

December 8th after branding.

@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit 8979ee3 into release/5.0 Dec 10, 2020
@AaronRobinsonMSFT
AaronRobinsonMSFT deleted the backport/pr-45500-to-release/5.0 branch December 10, 2020 22:00
@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants