Fix GNU linker detection on FreeBSD - #45664
Merged
Merged
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @ViktorHofer Issue DetailsIn #37753, we unified linker detection by version output string. At the time, only cross compilation of FreeBSD was validated, but on the OS, the output looks like: $ clang -Wl,--version
LLD 10.0.1 (FreeBSD llvmorg-10.0.1-0-gef32c611aa2-1200012) (compatible with GNU linkers)This PR fixes CoreCLR build on FreeBSD and build succeeds. Fixes #45663
|
This was referenced Dec 7, 2020
Closed
|
Thanks! |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #37753, we unified linker detection by version output string. At the time, only cross compilation of FreeBSD was validated, but on the OS, the output looks like:
This PR fixes CoreCLR build on FreeBSD and build succeeds.
Fixes #45663
cc @janvorli, @Thefrank