Skip to content

Add Microsoft StrongNameKey back to System.Composition* #45756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 1 commit into from
Dec 8, 2020
Merged

Add Microsoft StrongNameKey back to System.Composition* #45756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/System.Composition/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<Project>
<Import Project="..\Directory.Build.props" />
</Project>
<PropertyGroup>
<StrongNameKeyId>Microsoft</StrongNameKeyId>

@ericstj ericstj Dec 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an APICompat run that should have caught this or is APICompat ignoring PKT?

@ViktorHofer ViktorHofer Dec 8, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my assumption as well. I believe APICompat currently doesn't validate the PKT in the assembly metadata:

.assembly extern System.Composition.AttributedModel
{
  .publickeytoken = (CC 7B 13 FF CD 2D DD 51 )                         // .{...-.Q
  .ver 5:0:0:0
}

@ericstj ericstj Dec 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there were some intentional differences, back in Silverlight days and the runtime supported it. Those should be paired with [assembly: AssemblyFlags(AssemblyNameFlags.Retargetable)]. I wonder if we could add this attribute to make it compatible with folks who compiled against the bad PKT 🤔
cc @safern who's looking at API compat scenarios.

</PropertyGroup>
</Project>