[mono] Remove MonoListItem from Corelib - #47174
Merged
Merged
Conversation
CoffeeFlux
requested review from
BrzVlad,
EgorBo,
akoeplinger,
marek-safar,
steveisok,
thaystg and
vargaz
as code owners
January 19, 2021 17:33
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsHopefully this doesn't break anything, but admittedly the array handling here is kind of ugly.
|
lambdageek
approved these changes
Jan 19, 2021
CoffeeFlux
force-pushed
the
remove-monomlist
branch
from
January 19, 2021 18:10
9c88f95 to
c572aa1
Compare
Contributor
|
Why is this needed ? |
Contributor
Author
|
Size reduction, mostly. A bunch of the native mlist stuff was being held, and it is marginally shrinking corelib. |
CoffeeFlux
force-pushed
the
remove-monomlist
branch
from
January 27, 2021 16:40
c572aa1 to
f143f7d
Compare
Contributor
|
MonoListItem is just a simple class with 2 members and no methods, so this is not going to save much. |
Contributor
Author
|
It holds the mono-mlist stuff on the native side too. I doubt the savings are huge, but it was a pretty easy cleanup. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this doesn't break anything, but admittedly the array handling here is kind of ugly.