Skip to content

Improve msg for missing libicu #47511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 4 commits into from
Jan 28, 2021
Merged

Improve msg for missing libicu #47511

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1dd20d5
Improve msg for missing libicu
Jan 27, 2021
c15a29c
add comment
Jan 28, 2021
b6758e1
add aka.ms
Jan 28, 2021
e21338c
better link
Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,11 @@ private static bool GetGlobalizationInvariantMode()
int loaded = Interop.Globalization.LoadICU();
if (loaded == 0 && !OperatingSystem.IsBrowser())
{
// This can't go into resources, because a resource lookup requires globalization, which requires ICU
string message = "Couldn't find a valid ICU package installed on the system. " +
"Set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support.";
"Please install libicu using your package manager and try again. " +
"Alternatively you can set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support. " +
"Please see https://aka.ms/dotnet-missing-libicu for more information.";
Environment.FailFast(message);
}

Expand Down