Skip to content

Remove unused unicode header inclusion - #47840

Merged
safern merged 1 commit into
dotnet:masterfrom
am11:feature/icu
Feb 4, 2021
Merged

Remove unused unicode header inclusion#47840
safern merged 1 commit into
dotnet:masterfrom
am11:feature/icu

Conversation

@am11

@am11 am11 commented Feb 4, 2021

Copy link
Copy Markdown
Member

unicode/uclean.h was added in bdc8955 for u_init() when the PR was
WIP: https://github.com/dotnet/runtime/pull/37971/commits

By the time PR was merged, u_init() was removed, so this header is
not required by any configuration.

Fixes #47831

`unicode/uclean.h` was added in bdc8955 for `u_init()` when the PR was
WIP: https://github.com/dotnet/runtime/pull/37971/commits

By the time PR was merged, `u_init()` was removed, so this header is
not required by any configuration.
@ghost

ghost commented Feb 4, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

unicode/uclean.h was added in bdc8955 for u_init() when the PR was
WIP: https://github.com/dotnet/runtime/pull/37971/commits

By the time PR was merged, u_init() was removed, so this header is
not required by any configuration.

Fixes #47831

Author: am11
Assignees: -
Labels:

area-Build-mono, area-System.Globalization

Milestone: -

@safern

safern commented Feb 4, 2021

Copy link
Copy Markdown
Member

Timeouts on Android are being taken care of.

@safern
safern merged commit ce84910 into dotnet:master Feb 4, 2021
@am11
am11 deleted the feature/icu branch February 4, 2021 19:50
@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing unicode/uclean.h in mono M1 runtime build

3 participants