Skip to content

Include the iOS, Android, and macCatalyst supported platforms - #50143

Merged
jeffhandley merged 1 commit into
dotnet:mainfrom
jeffhandley:include-supported-platforms
Mar 24, 2021
Merged

Include the iOS, Android, and macCatalyst supported platforms#50143
jeffhandley merged 1 commit into
dotnet:mainfrom
jeffhandley:include-supported-platforms

Conversation

@jeffhandley

Copy link
Copy Markdown
Member

With dotnet/sdk#16489, we are removing iOS, Android, and macCatalyst from the default set of supported platforms that will be checked by the Platform Compatibility Analyzer. We intend to reintroduce those platforms into a default set with scoping to cover libraries; that will be handled by dotnet/sdk#16488. To ensure no gap in coverage of these platforms in dotnet/runtime though, this change explicitly adds those platforms back into our own build. These platforms are added in unconditionally as they were in the SDK default so that we maintain full continuity of that coverage.

@ghost

ghost commented Mar 24, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost

ghost commented Mar 24, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

With dotnet/sdk#16489, we are removing iOS, Android, and macCatalyst from the default set of supported platforms that will be checked by the Platform Compatibility Analyzer. We intend to reintroduce those platforms into a default set with scoping to cover libraries; that will be handled by dotnet/sdk#16488. To ensure no gap in coverage of these platforms in dotnet/runtime though, this change explicitly adds those platforms back into our own build. These platforms are added in unconditionally as they were in the SDK default so that we maintain full continuity of that coverage.

Author: jeffhandley
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@jeffhandley jeffhandley added this to the 6.0.0 milestone Mar 24, 2021
Comment thread eng/versioning.targets
</PropertyGroup>


<!-- Enables warnings for Android, iOS, and macCatalyst for all builds -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be unified with the logic bellow and disable them for tests?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered that, but thus far we've been OK having these platforms enabled for tests. I didn't want to loosen up any more than necessary, as that could add risk of dotnet/sdk#16488 introducing new warnings.

@jeffhandley
jeffhandley merged commit 8e187d1 into dotnet:main Mar 24, 2021
@jeffhandley
jeffhandley deleted the include-supported-platforms branch March 24, 2021 22:16
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants