-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add the ability to stop the Host when one of its BackgroundService instances errors
#50569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eerhardt
merged 17 commits into
dotnet:main
from
IEvangelist:background-service-ex-behavior
Apr 16, 2021
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3173bd7
Added background service exception behavior enum. Update HostOptions …
IEvangelist 91a31ec
Added corresponding unit tests for host when ignoring or stopping.
IEvangelist a49fde9
Call StopAsync rather than FailFast
IEvangelist 2e611e1
Manually update String.resx outside of VS GUI
IEvangelist 0819a2d
Remove the RemoteExecutor, as it is no longer needed.
IEvangelist e985ec5
Call `IApplicationLifetime.StopApplication()` instead of `StopAsync()`.
IEvangelist 28ccffc
Moved enum out of abstractions. Encapsulate logging logic in extensio…
IEvangelist c9356b8
Set the default as `StopHost`
IEvangelist 4632446
Move ref bits from hosting.abstractions to hosting proper.
IEvangelist a74d694
Address feedback from peer review
IEvangelist 4737d98
Added unit test to verify background service 1 gets started, and runs…
IEvangelist 5cd1705
Use explicitly controlled timing for unit test and remove args: ex
IEvangelist bad7af5
Convert from Fact, to Theory. Test both enum values.
IEvangelist aeb6a56
Adjusted test case, per @eerhardt
IEvangelist d9c642d
Fix test hang issue
IEvangelist 71c1f26
Separate StartAsync and ExecuteTask, let StartAsync bubble. Adjust un…
IEvangelist 3d4c11c
Update the background service async exceptions get logged unit test
IEvangelist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
src/libraries/Microsoft.Extensions.Hosting/src/BackgroundServiceExceptionBehavior.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace Microsoft.Extensions.Hosting | ||
| { | ||
| /// <summary> | ||
| /// Specifies a behavior that the <see cref="IHost"/> will honor if an | ||
| /// unhandled exception occurs in one of its <see cref="BackgroundService"/> instances. | ||
| /// </summary> | ||
| public enum BackgroundServiceExceptionBehavior | ||
| { | ||
| /// <summary> | ||
| /// Stops the <see cref="IHost"/> instance. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// If a <see cref="BackgroundService"/> throws an exception, the <see cref="IHost"/> instance stops, and the process continues. | ||
| /// </remarks> | ||
| StopHost = 0, | ||
|
|
||
| /// <summary> | ||
| /// Ignore exceptions thrown in <see cref="BackgroundService"/>. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// If a <see cref="BackgroundService"/> throws an exception, the <see cref="IHost"/> will log the error, but otherwise ignore it. | ||
| /// The <see cref="BackgroundService"/> is not restarted. | ||
| /// </remarks> | ||
| Ignore = 1 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.