System.Text.Json: Add IAsyncEnumerable support#50778

Merged

eiriktsarpalis merged 27 commits into

dotnet:mainfrom

eiriktsarpalis:IAsync

Apr 12, 2021

Member

eiriktsarpalis commented Apr 6, 2021 •

edited

Loading

Fixes #1570.

FYI @pranavkm @ericstj

eiriktsarpalis added the area-System.Text.Json label

eiriktsarpalis added this to the 6.0.0 milestone

eiriktsarpalis requested review from layomia and steveharter

April 6, 2021 11:44

eiriktsarpalis self-assigned this

eiriktsarpalis requested a review from jozkee as a code owner

April 6, 2021 11:44

ghost added the new-api-needs-documentation label

ghost commented Apr 6, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost commented Apr 6, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #1570.

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	`area-System.Text.Json`
Milestone:	6.0.0

stephentoub reviewed

View reviewed changes

.../System.Text.Json/src/System/Text/Json/Serialization/AsyncEnumerableStreamingDeserializer.cs Outdated

stephentoub reviewed

View reviewed changes

...src/System/Text/Json/Serialization/Converters/Collection/IAsyncEnumerableConverterFactory.cs Outdated

stephentoub reviewed

View reviewed changes

...src/System/Text/Json/Serialization/Converters/Collection/IAsyncEnumerableConverterFactory.cs Outdated

stephentoub reviewed

View reviewed changes

...son/src/System/Text/Json/Serialization/Converters/Collection/IAsyncEnumerableOfTConverter.cs Outdated

stephentoub reviewed

View reviewed changes

...son/src/System/Text/Json/Serialization/Converters/Collection/IAsyncEnumerableOfTConverter.cs Outdated

stephentoub reviewed

View reviewed changes

...son/src/System/Text/Json/Serialization/Converters/Collection/IAsyncEnumerableOfTConverter.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Stream.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Stream.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadAsyncState.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated

stephentoub reviewed

View reviewed changes

.../System.Text.Json/src/System/Text/Json/Serialization/AsyncEnumerableStreamingDeserializer.cs Outdated

stephentoub reviewed

View reviewed changes

src/libraries/System.Text.Json/ref/System.Text.Json.cs Outdated

stephentoub reviewed

View reviewed changes

...libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Write.Stream.cs Outdated

steveharter reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System.Text.Json.csproj Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ClassType.cs Outdated

...System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/JsonObjectConverter.cs Outdated

...ries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.AsyncEnumerable.cs Outdated

...ries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.AsyncEnumerable.cs Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStackFrame.cs Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated

...ries/System.Text.Json/tests/Serialization/CollectionTests/CollectionTests.AsyncEnumerable.cs Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadAsyncState.cs Outdated

eiriktsarpalis mentioned this pull request

System.Text.Json not properly disposing enumerators on exceptions #50851

Closed

layomia reviewed

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadAsyncState.cs Outdated

.../System.Text.Json/src/System/Text/Json/Serialization/AsyncEnumerableStreamingDeserializer.cs Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated

...son/src/System/Text/Json/Serialization/Converters/Collection/IAsyncEnumerableOfTConverter.cs Outdated

...System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/JsonObjectConverter.cs Outdated

...System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/JsonObjectConverter.cs Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadAsyncState.cs Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadAsyncState.cs Outdated

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs Outdated

eiriktsarpalis added the breaking-change label

ghost added the needs-breaking-change-doc-created label

eiriktsarpalis and others added 17 commits

April 9, 2021 16:46


          tweak test buffer values

3eec24c


          Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…

917d630

…ion/Converters/Collection/IAsyncEnumerableOfTConverter.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>


          Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…

ebdce43

…ion/Converters/Collection/IAsyncEnumerableOfTConverter.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>


          address feedback

ae83e8c


          increase delayInterval in serialization tests

102ed44


          address feedback

197fdce


          address feedback

8ee1051


          add test on exceptional IAsyncDisposable disposal

9a03fed


          address feedback

537dc54


          Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…

c5f57b4

…ion/ReadAsyncState.cs

Co-authored-by: Layomi Akinrinade <layomia@gmail.com>


          Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…

68f71c7

…ion/WriteStack.cs

Co-authored-by: Layomi Akinrinade <layomia@gmail.com>


          fix build and remove dead code

bfc0e7b


          address feedback

65b2ec4


          Revert unneeded JsonClassInfo.ElementType workaround

9ccf772


          remove state allocation on async deserialization methods

ac56fb3


          remove tooling artifacts

d893083


          address feedback

2a5b5f1

eiriktsarpalis force-pushed the IAsync branch from c20de42 to 2a5b5f1 Compare

April 9, 2021 15:46


          reset AsyncEnumeratorIsPendingCompletion field

77fc902

eiriktsarpalis merged commit 81d3a99 into dotnet:main

eiriktsarpalis deleted the IAsync branch

April 12, 2021 16:06

marek-safar mentioned this pull request

Trimmed System.Text.Json size for Blazor regression #51314

Closed

eerhardt mentioned this pull request

Blazor Wasm - Size regression in System.Text.Json.dll #51311

Closed

DrewScoggins mentioned this pull request

[Perf] Changes at 4/12/2021 5:01:25 PM DrewScoggins/performance-2#5151

Open

davidfowl mentioned this pull request

[.NET 6 Preview 4] Command is already in progress error in Npgsql library dotnet/aspnetcore#32254

Closed

eiriktsarpalis mentioned this pull request

API Proposal: System.Text.Json: IAsyncEnumerable support #38055

Closed

This was referenced May 12, 2021

Regression in Caching TechEmpower benchmark #52640

Closed

[Windows] Regression in few TechEmpower benchmarks aspnet/Benchmarks#1668

Closed

ghost locked as resolved and limited conversation to collaborators

eiriktsarpalis removed the needs-breaking-change-doc-created label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Text.Json breaking-change new-api-needs-documentation