Skip to content

Allow region_allocator to allocate from the right - #50973

Merged
cshung merged 5 commits into
dotnet:mainfrom
cshung:public/move-poh-right
Apr 21, 2021
Merged

Allow region_allocator to allocate from the right#50973
cshung merged 5 commits into
dotnet:mainfrom
cshung:public/move-poh-right

Conversation

@cshung

@cshung cshung commented Apr 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Remove the parts where I allocate the POH regions from the right-hand side, the remaining parts of the system is not ready for that yet.

@ghost

ghost commented Apr 8, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: cshung
Assignees: -
Labels:

area-GC-coreclr
Milestone: -

@cshung
cshung marked this pull request as draft April 8, 2021 21:48
@cshung cshung changed the title Move POH regions to the higher VA side Allow region_allocator to allocate from the right Apr 9, 2021
cshung
cshung commented Apr 9, 2021
View reviewed changes

@cshung cshung left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noted a couple of things I will change.

Comment thread src/coreclr/gc/gc.cpp Outdated
Comment thread src/coreclr/gc/gcpriv.h Outdated
@cshung
cshung force-pushed the public/move-poh-right branch from b7281c8 to 3ded428 Compare April 15, 2021 00:39
@cshung
cshung marked this pull request as ready for review April 16, 2021 16:05
Maoni0
Maoni0 reviewed Apr 19, 2021
View reviewed changes
Comment thread src/coreclr/gc/gc.cpp Outdated
Maoni0
Maoni0 reviewed Apr 19, 2021
View reviewed changes
Comment thread src/coreclr/gc/gc.cpp Outdated
Maoni0
Maoni0 reviewed Apr 19, 2021
View reviewed changes
Comment thread src/coreclr/gc/gc.cpp Outdated
Maoni0
Maoni0 reviewed Apr 19, 2021
View reviewed changes
Comment thread src/coreclr/gc/gcpriv.h Outdated
Maoni0
Maoni0 reviewed Apr 19, 2021
View reviewed changes
Comment thread src/coreclr/gc/gc.cpp Outdated
Maoni0
Maoni0 reviewed Apr 20, 2021
View reviewed changes
Comment thread src/coreclr/gc/gc.cpp Outdated
Maoni0
Maoni0 reviewed Apr 20, 2021
View reviewed changes
Comment thread src/coreclr/gc/gc.cpp Outdated
Maoni0
Maoni0 approved these changes Apr 20, 2021
View reviewed changes

@Maoni0 Maoni0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than changing the last places to use the enum, this LGTM

@cshung
cshung force-pushed the public/move-poh-right branch from 6d04b82 to 69804f6 Compare April 21, 2021 16:03
@runfoapp runfoapp Bot mentioned this pull request Apr 21, 2021
Closed
@cshung
cshung merged commit 2257dad into dotnet:main Apr 21, 2021
@cshung
cshung deleted the public/move-poh-right branch April 21, 2021 20:32
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

Assignees

No one assigned

Labels

area-GC-coreclr

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cshung @Maoni0 @karelz