Skip to content

Add stub definitions of inject debug resources targets to fix runtimeinfo build dependency issues. #51254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 1 commit into from
Apr 15, 2021
Merged

Add stub definitions of inject debug resources targets to fix runtimeinfo build dependency issues. #51254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/coreclr/dlls/mscoree/coreclr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ if(CLR_CMAKE_TARGET_WIN32)
add_custom_target(inject_debug_resources_singlefilehost ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/inject_debug_resources_singlefilehost.timestamp)
add_dependencies(runtime inject_debug_resources_singlefilehost)
endif()
else()
add_custom_target(inject_debug_resources_coreclr DEPENDS coreclr)

@hoyosjs hoyosjs Apr 14, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing that we could do is make runtimeinfo depend on inject_debug_resources_coreclr on windows, given that conceptually there's no external resources needed for debugging coreclr. Do you have a preference between the dependencies vs this phony target?

@jkoritzinsky jkoritzinsky Apr 14, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather do the phony target so we don't need to add a different dependency that has the same effect on non-Windows platforms.

add_custom_target(inject_debug_resources_singlefilehost DEPENDS singlefilehost)
endif(CLR_CMAKE_TARGET_WIN32)

# add the install targets
Expand Down