Skip to content

Reduce unnecessary casting in SslStreamPal - #51324

Merged
marek-safar merged 1 commit into
dotnet:mainfrom
benaadams:SslStream-casting
Apr 19, 2021
Merged

Reduce unnecessary casting in SslStreamPal#51324
marek-safar merged 1 commit into
dotnet:mainfrom
benaadams:SslStream-casting

Conversation

@benaadams

@benaadams benaadams commented Apr 15, 2021

Copy link
Copy Markdown
Member

Can pass a more strongly typed sealed derived type in.

@ghost

ghost commented Apr 15, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: benaadams
Assignees: -
Labels:

area-System.Net.Security

Milestone: -

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is green, LGTM

@benaadams

Copy link
Copy Markdown
Member Author

If CI is green, LGTM

Will need to rerun after this is fixed #51346

@benaadams

Copy link
Copy Markdown
Member Author

Lot of weird failures on runtime-staging 🤔

@stephentoub stephentoub reopened this Apr 17, 2021
@marek-safar
marek-safar merged commit ccc47f5 into dotnet:main Apr 19, 2021
@benaadams
benaadams deleted the SslStream-casting branch April 19, 2021 14:41
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants