Skip to content

Fix references to MDArray methods - #52796

Merged
jkotas merged 1 commit into
dotnet:mainfrom
davidwrighton:fix_52703
May 15, 2021
Merged

Fix references to MDArray methods#52796
jkotas merged 1 commit into
dotnet:mainfrom
davidwrighton:fix_52703

Conversation

@davidwrighton

@davidwrighton davidwrighton commented May 14, 2021

Copy link
Copy Markdown
Member
  • References to the Array methods follow special rules, one of which is that the lobounds/range of the array type is immaterial in the signatures of those methods.
  • Fix the problem identified in Crossgen2 unable to find methods on MdArrays #52703 and add a test to our type system test suite so that it doesn't come back

Fixes #52703

@ghost ghost added the area-ReadyToRun label May 14, 2021
jkotas
jkotas approved these changes May 15, 2021
View reviewed changes

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas
jkotas merged commit 7db5438 into dotnet:main May 15, 2021
trylek
trylek reviewed May 16, 2021
View reviewed changes

@trylek trylek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMT

@MichalStrehovsky MichalStrehovsky mentioned this pull request May 20, 2021
Closed
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
@davidwrighton
davidwrighton deleted the fix_52703 branch April 13, 2023 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylek trylek trylek left review comments
@jkotas jkotas jkotas approved these changes
@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

No one assigned

Labels

area-ReadyToRun

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Crossgen2 unable to find methods on MdArrays

4 participants

@davidwrighton @jkotas @trylek @karelz