Skip to content

Expose Array.Clear(Array) publicly - #53388

Merged
GrabYourPitchforks merged 5 commits into
dotnet:mainfrom
GrabYourPitchforks:arr_clear
May 28, 2021
Merged

Expose Array.Clear(Array) publicly#53388
GrabYourPitchforks merged 5 commits into
dotnet:mainfrom
GrabYourPitchforks:arr_clear

Conversation

@GrabYourPitchforks

Copy link
Copy Markdown
Member

Resolves #51581.

Not all calls to Array.Clear(Array, int, int) were changed. The three excluded categories are:

  • where the call site occurs within an assembly which targets downlevel API surface;
  • where the call site occurs within the Array unit test project itself; or
  • where the call site is in code which should remain untouched for compliance purposes.

@ghost

ghost commented May 27, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented May 27, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @tannergooding
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolves #51581.

Not all calls to Array.Clear(Array, int, int) were changed. The three excluded categories are:

  • where the call site occurs within an assembly which targets downlevel API surface;
  • where the call site occurs within the Array unit test project itself; or
  • where the call site is in code which should remain untouched for compliance purposes.
Author: GrabYourPitchforks
Assignees: -
Labels:

area-System.Runtime

Milestone: 6.0.0

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@davidfowl

Copy link
Copy Markdown
Member

So no more array.AsSpan().Clear()

@GrabYourPitchforks

Copy link
Copy Markdown
Member Author

Test failures are known issue #53405.

@GrabYourPitchforks
GrabYourPitchforks merged commit b759ac9 into dotnet:main May 28, 2021
@GrabYourPitchforks
GrabYourPitchforks deleted the arr_clear branch May 28, 2021 04:08
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API proposal: Array.Clear(Array)

4 participants