Skip to content

[wasm] Skip tests for ExpectContinue HTTP header #57058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelsavara merged 2 commits into from
Aug 9, 2021
Merged

[wasm] Skip tests for ExpectContinue HTTP header #57058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c538277
throw PlatformNotSupportedException for ExpectContinue and Expect hea…
pavelsavara Aug 9, 2021
04bc52f
feedback
pavelsavara Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ public static IEnumerable<object[]> ExpectContinueVersion()
[OuterLoop("Uses external servers", typeof(PlatformDetection), nameof(PlatformDetection.LocalEchoServerIsNotAvailable))]
[Theory]
[MemberData(nameof(ExpectContinueVersion))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53876", TestPlatforms.Browser)]
[SkipOnPlatform(TestPlatforms.Browser, "ExpectContinue not supported on Browser")]
public async Task PostAsync_ExpectContinue_Success(bool? expectContinue, Version version)
{
// Sync API supported only up to HTTP/1.1
Expand Down
6 changes: 4 additions & 2 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,10 +429,10 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
if (PlatformDetection.IsNotBrowser)
{
request.Content.Headers.ContentMD5 = MD5.Create().ComputeHash(contentArray);
request.Headers.Expect.Add(new NameValueWithParametersHeaderValue("100-continue"));
}
request.Content.Headers.ContentType = new MediaTypeHeaderValue("application/x-www-form-urlencoded");
request.Headers.Date = DateTimeOffset.Parse("Tue, 15 Nov 1994 08:12:31 GMT");
request.Headers.Expect.Add(new NameValueWithParametersHeaderValue("100-continue"));
request.Headers.Add("Forwarded", "for=192.0.2.60;proto=http;by=203.0.113.43");
request.Headers.Add("From", "User Name <user@example.com>");
request.Headers.Host = "en.wikipedia.org:8080";
Expand Down Expand Up @@ -1369,7 +1369,7 @@ public async Task GetAsync_UnicodeHostName_SuccessStatusCodeInResponse()
#region Post Methods Tests

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/53876", TestPlatforms.Browser)]
[SkipOnPlatform(TestPlatforms.Browser, "ExpectContinue not supported on Browser")]
public async Task GetAsync_ExpectContinueTrue_NoContent_StillSendsHeader()
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down Expand Up @@ -1547,6 +1547,7 @@ await server.AcceptConnectionAsync(async connection =>
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "ExpectContinue not supported on Browser")]
public async Task SendAsync_MultipleExpected100Responses_ReceivesCorrectResponse()
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down Expand Up @@ -1642,6 +1643,7 @@ await server.AcceptConnectionAsync(async connection =>
}

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "ExpectContinue not supported on Browser")]
public async Task SendAsync_No100ContinueReceived_RequestBodySentEventually()
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down