Skip to content

Cancelled writes hypothesis #57212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsitnik wants to merge 3 commits into from
Closed

Cancelled writes hypothesis #57212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a01a883
validate hypothesis that numBytes != 0 for cancelled writes on Win 7 x86
adamsitnik Aug 11, 2021
cdfd100
run it 10k times to make sure the problem is hit by the CI
adamsitnik Aug 11, 2021
8d00e2a
change sth to re-trigger the CI
adamsitnik Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/libraries/System.IO.FileSystem/tests/FileStream/WriteAsync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,15 +100,27 @@ public async Task SimpleWriteAsync()
}
}

[Fact]
public async Task TriggerTheProblemAsync()
{
if (OperatingSystem.IsWindows())
{
for (int i = 0; i < 10_000; i++)
{
await WriteAsyncCancelledFile(0, FileOptions.Asynchronous | FileOptions.DeleteOnClose);
}
}
}

[Theory]
[InlineData(0, true)] // 0 == no buffering
[InlineData(4096, true)] // 4096 == default buffer size
[InlineData(0, false)]
[InlineData(4096, false)]
public async Task WriteAsyncCancelledFile(int bufferSize, bool isAsync)
[InlineData(0, FileOptions.Asynchronous)] // 0 == no buffering
[InlineData(4096, FileOptions.Asynchronous)] // 4096 == default buffer size
[InlineData(0, FileOptions.None)]
[InlineData(4096, FileOptions.None)]
public async Task WriteAsyncCancelledFile(int bufferSize, FileOptions fileOptions)
{
const int writeSize = 1024 * 1024;
using (FileStream fs = new FileStream(GetTestFilePath(), FileMode.CreateNew, FileAccess.Write, FileShare.None, bufferSize, isAsync))
using (FileStream fs = new FileStream(GetTestFilePath(), FileMode.CreateNew, FileAccess.Write, FileShare.None, bufferSize, fileOptions))
{
byte[] buffer = new byte[writeSize];
CancellationTokenSource cts = new CancellationTokenSource();
Expand Down
6 changes: 6 additions & 0 deletions ...reLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.OverlappedValueTaskSource.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,12 @@ internal void Complete(uint errorCode, uint numBytes)
OSFileStreamStrategy? strategy = _strategy;
ReleaseResources();

if (errorCode != Interop.Errors.ERROR_SUCCESS && numBytes != 0)
{
_source.SetException(new Exception($"The error code was {errorCode} and numBytes was {numBytes}"));
return;
}

if (strategy is not null && _bufferSize != numBytes) // true only for incomplete operations
{
strategy.OnIncompleteOperation(_bufferSize, (int)numBytes);
Expand Down