Skip to content

Throwing FormatException when a required property from Microsoft.Extensions.DependencyModel is empy #60842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 18 commits into from
Nov 2, 2021
Merged

Throwing FormatException when a required property from Microsoft.Extensions.DependencyModel is empy #60842

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6646df9
Setting framework name as nullable.
filipjelic Oct 25, 2021
bf0adc0
Setting path to nullable.
filipjelic Oct 25, 2021
7a7c260
Setting runtime to nullable.
filipjelic Oct 25, 2021
e3c9d35
Setting path to nullable.
filipjelic Oct 25, 2021
ef7fd3c
Setting Target Name, RuntimeTargetEntrySub Path and TargetLibrary Nam…
filipjelic Oct 25, 2021
834881c
Adding missing line of code.
filipjelic Oct 26, 2021
96febc3
Merge branch 'main' into SettingNullableTargetName
filipjelic Oct 26, 2021
3560d0d
Adding new string resource and throwing argument exception on null/em…
filipjelic Oct 27, 2021
629b2c1
Merge branch 'main' into SettingNullableTargetName
filipjelic Oct 28, 2021
1871188
Removing Argument from string resource.
filipjelic Oct 28, 2021
ef74b15
Updating unit tests to use FormatException
filipjelic Oct 28, 2021
10338cb
Rollback of ArgumentExceptions in DependencyModels
filipjelic Oct 28, 2021
83a32ab
Added missing usings
filipjelic Oct 28, 2021
459ae57
Updating all exceptions to FormatException
filipjelic Oct 28, 2021
acec1f6
Moving FormatException while reading target name
filipjelic Oct 28, 2021
edfdd6d
Updating PR with new comments.
filipjelic Oct 28, 2021
457530c
Update src/libraries/Microsoft.Extensions.DependencyModel/src/Depende…
filipjelic Oct 28, 2021
cbc2321
Merge branch 'main' into SettingNullableTargetName
filipjelic Oct 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Setting path to nullable.
  • Loading branch information
@filipjelic
filipjelic committed Oct 25, 2021
commit e3c9d3576ee39d5948493d36bd2cfb128982876d
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Extensions.DependencyModel/src/ResourceAssembly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Microsoft.Extensions.DependencyModel
{
public class ResourceAssembly
{
public ResourceAssembly(string path, string locale)
public ResourceAssembly(string? path, string locale)
{
if (string.IsNullOrEmpty(path))
{
Expand Down