Skip to content

Get rid of fallback to process ids enumeration in ProcessManager.IsProcessRunning (Windows) #65041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 2 commits into from
Mar 14, 2022
Merged

Get rid of fallback to process ids enumeration in ProcessManager.IsProcessRunning (Windows) #65041

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a7c2a1
ProcessManager.IsRunning on Windows: Idle process handle couldn't be …
Feb 3, 2022
cce266a
Peformance optimization in ProcessManager.IsRunning on Windows: Enume…
Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,22 @@ public static bool IsProcessRunning(int processId, string machineName)
{
// Performance optimization for the local machine:
// First try to OpenProcess by id, if valid handle is returned verify that process is running
// Otherwise enumerate all processes and compare ids
if (!IsRemoteMachine(machineName))
// When the attempt to open a handle fails due to lack of permissions enumerate all processes and compare ids
// Attempt to open handle for Idle process (processId == 0) fails with ERROR_INVALID_PARAMETER
if (processId != 0 && !IsRemoteMachine(machineName))
{
using (SafeProcessHandle processHandle = Interop.Kernel32.OpenProcess(ProcessOptions.PROCESS_QUERY_LIMITED_INFORMATION | ProcessOptions.SYNCHRONIZE, false, processId))
{
if (!processHandle.IsInvalid)
if (processHandle.IsInvalid)
{
int error = Marshal.GetLastWin32Error();
if (error == Interop.Errors.ERROR_INVALID_PARAMETER)
{
Debug.Assert(processId != 0, "OpenProcess fails with ERROR_INVALID_PARAMETER for Idle Process");
return false;
}
}
else
{
bool signaled = false;
return !HasExited(processHandle, ref signaled, out _);
Expand Down