Revert genCall register trash changes from CFG PR#65397
Revert genCall register trash changes from CFG PR#65397jakobbotsch wants to merge 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsRevert these particular fragments back to what they were before CFG. Fix #65395
|
|
cc @dotnet/jit-contrib @echesakovMSFT |
Revert these particular fragments back to what they were before CFG. This should fix outerloop but I will need to take a closer look tomorrow as this particular code is not right for the CFG validator. Fix dotnet#65395
jakobbotsch
force-pushed
the
fix-65395
branch
from
d477261 to
8e981cc
Compare
|
does it fix #65311 ? |
No, doesn't look like it does. |
echesakov
left a comment
echesakov
left a comment
There was a problem hiding this comment.
Looks fine to unblock outerloop.
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Note that this failed in runtime-coreclr jitstressregs pipeline originally. |
Ah.. will run that one then. |
|
/azp run runtime-coreclr jitstressregs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The NativeAOT leg is failing in the CFG test with It's difficult to find this assert in the wall of warning spew. I've submitted #65423 to clean the noise up. |
Right.. that's not super surprising given this is why I changed this code in the first place, so the code here should have been guarded on CFG. Guess that's what I get for late-night PR'ing. |
|
Superseded by #65432. |
ghost
locked as resolved and limited conversation to collaborators
4 participants
Revert these particular fragments back to what they were before CFG.
This should fix outerloop but I will need to take a closer look tomorrow
as this particular code is not right for the CFG validator.
Fix #65395