Swap out a Debug.Fail for a more graceful diagnostic failure.#65861
Merged
jkoritzinsky merged 2 commits intodotnet:mainfrom Feb 24, 2022
Merged
Swap out a Debug.Fail for a more graceful diagnostic failure.#65861jkoritzinsky merged 2 commits intodotnet:mainfrom
jkoritzinsky merged 2 commits intodotnet:mainfrom
Conversation
This case will never trigger in a release application, but can trigger when switching branches where each branch has a different definition of GeneratedDllImport.
ghost
added
the
jkoritzinsky
added
the
source-generator
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThis case will never trigger in a release application, but can trigger when switching branches where each branch has a different definition of GeneratedDllImport. This fix was requested by @stephentoub over email.
|
Member
Thanks. I'm finicky and like it when my IDE doesn't hang :) |
stephentoub
approved these changes
Feb 24, 2022
src/libraries/System.Runtime.InteropServices/gen/DllImportGenerator/DllImportGenerator.cs
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Feb 24, 2022
elinor-fung
approved these changes
Feb 24, 2022
Member
Author
|
CrossOS DAC failure is a known issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This case will never trigger in a release application, but can trigger when switching branches where each branch has a different definition of GeneratedDllImport.
This fix was requested by @stephentoub over email.