Await pending client authentication task before disposing#66682
Merged
rzikm merged 1 commit intodotnet:mainfrom Mar 16, 2022
Merged
Await pending client authentication task before disposing#66682rzikm merged 1 commit intodotnet:mainfrom
rzikm merged 1 commit intodotnet:mainfrom
Conversation
Fixes dotnet#65455. The assert was hit due to the SslStream being disposed during handshake, while `AuthenticateAsClientAsync` was still running.
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsFixes #65455. The assert was hit due to the SslStream being disposed during handshake, while
|
stephentoub
approved these changes
Mar 15, 2022
Member
Author
|
Test failures are unrelated |
Member
|
I think this is wrong fix. SslStream can be disposed while in use. Avoiding that in our tests is not the right answer IMHO. |
Member
Author
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
Fixes dotnet#65455. The assert was hit due to the SslStream being disposed during handshake, while `AuthenticateAsClientAsync` was still running. This removes a rare crash in test runs with debug libraries configuration.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65455.
The assert was hit due to the SslStream being disposed during handshake, while
AuthenticateAsClientAsyncwas still running.