Initial refactoring before fixing evaluation of methods on primitives. - #66704
Closed
ilonatommy wants to merge 1 commit into
Closed
Initial refactoring before fixing evaluation of methods on primitives.#66704ilonatommy wants to merge 1 commit into
ilonatommy wants to merge 1 commit into
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAs suggested in #66654 (review), it's a PR with an initial refactoring to make the methods-on-primitives PR look more legible.
|
Member
|
What is the motivation for this change? I'm not against the idea of splitting, but it does come with the cost of losing the history on it. It would become difficult to track/blame for past changes. So, curious about the motivation. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #66654 (review), it's a PR with an initial refactoring to make the methods-on-primitives PR look more legible.