Skip to content

Improve JsonTestHelpers.AssertJsonEqual error messages - #67973

Merged
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:jsontesthelper-improvements
Apr 15, 2022
Merged

Improve JsonTestHelpers.AssertJsonEqual error messages#67973
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:jsontesthelper-improvements

Conversation

@eiriktsarpalis

Copy link
Copy Markdown
Member

Improves assertion error messages in the JsonTestHelpers.AssertJsonEqual helper method.

Before:
image

After:
image

Change extracted from #67961.

@ghost

ghost commented Apr 13, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Improves assertion error messages in the JsonTestHelpers.AssertJsonEqual helper method.

Before:
image

After:
image

Change extracted from #67961.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json

Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Apr 13, 2022

@layomia layomia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Comment thread src/libraries/System.Text.Json/tests/Common/JsonTestHelper.cs Outdated
@eiriktsarpalis
eiriktsarpalis merged commit 599f0bc into dotnet:main Apr 15, 2022
@eiriktsarpalis
eiriktsarpalis deleted the jsontesthelper-improvements branch April 15, 2022 15:46
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants