Skip to content

Reenable GetHostAddressesTest_Cancellation on Unix#70009

Merged
rzikm merged 1 commit into
dotnet:mainfrom
rzikm:reenable-dns-tests
May 31, 2022
Merged

Reenable GetHostAddressesTest_Cancellation on Unix#70009
rzikm merged 1 commit into
dotnet:mainfrom
rzikm:reenable-dns-tests

Conversation

@rzikm

@rzikm rzikm commented May 31, 2022

Copy link
Copy Markdown
Member

The original issue (#33378) is marked as closed by (#34633).

@ghost ghost assigned rzikm May 31, 2022
@ghost ghost added the area-System.Net label May 31, 2022
@ghost

ghost commented May 31, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

The original issue (#33378) is marked as closed by (#34633).

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net
Milestone: -

@wfurt

wfurt commented May 31, 2022

Copy link
Copy Markdown
Member

do we know if anything releavent changed or is this just opportunistic?

@rzikm

rzikm commented May 31, 2022

Copy link
Copy Markdown
Member Author

I have just noticed this when looking at #69993

stephentoub
stephentoub approved these changes May 31, 2022
View reviewed changes

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they work, LGTM

@rzikm
rzikm merged commit e8b9592 into dotnet:main May 31, 2022
@antonfirsov

antonfirsov commented Jun 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

#34633 has been reverted, there is still no async name resolution and cancellation support on Linux, therefore we should undo this PR.

There was a GitHub bookkeeping problem casing confusion with [ActiveIssue()] referencing a closed issue #33378 (with the "solution" eventually reverted).

rzikm added a commit to rzikm/dotnet-runtime that referenced this pull request Jun 1, 2022
@rzikm
Revert "Reenable GetHostAddressesTest_Cancellation on Unix (dotnet#70009
becd2bf 
)"

This reverts commit e8b9592.
@rzikm rzikm mentioned this pull request Jun 1, 2022
Merged
@antonfirsov antonfirsov mentioned this pull request Jun 1, 2022
Merged
rzikm added a commit that referenced this pull request Jun 2, 2022
@rzikm
Disable flaky DNS cancellation tests during jitstress (#70089)
f873951 
* Revert "Reenable GetHostAddressesTest_Cancellation on Unix (#70009)"

This reverts commit e8b9592.

* Revert "Fix flakyness of DnsGetHostAddresses_PostCancelledToken_Throws (#70044)"

This reverts commit a466063.

* Disable flaky tests on jitstress

* fixup! Disable flaky tests on jitstress
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@rzikm rzikm

Labels

area-System.Net

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rzikm @wfurt @antonfirsov @stephentoub @karelz