Skip to content

Move host changes from liveBuilds to externals - #72583

Closed
agocke wants to merge 2 commits into
dotnet:mainfrom
agocke:fix-runtime-pkg
Closed

Move host changes from liveBuilds to externals#72583
agocke wants to merge 2 commits into
dotnet:mainfrom
agocke:fix-runtime-pkg

Conversation

@agocke

@agocke agocke commented Jul 21, 2022

Copy link
Copy Markdown
Member

The changes in liveBuilds affected the package construction, causing the
host files (hostfxr and hostpolicy) to be included in the runtime shared
framework package, which they should not be. This later caused issues
because Red Hat doesn't allow multiple packages to ship identical binaries
with debugging information.

The changes in liveBuilds affected the package construction, causing the
host files (hostfxr and hostpolicy) to be included in the runtime shared
framework package, which they should not be. This later caused issues
because Red Hat doesn't allow multiple packages to ship identical binaries
with debugging information.
@agocke

agocke commented Jul 21, 2022

Copy link
Copy Markdown
Member Author

I think this will fix the failures in dotnet/installer#14170

@ghost

ghost commented Jul 21, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

The changes in liveBuilds affected the package construction, causing the
host files (hostfxr and hostpolicy) to be included in the runtime shared
framework package, which they should not be. This later caused issues
because Red Hat doesn't allow multiple packages to ship identical binaries
with debugging information.

Author: agocke
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

- name: BuildArguments
value: >-
-subset host+packs -ci
-subset host+libs.pretest+packs -ci

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this change surprises me. Why would we need libs.pretest in the installer partition?

@agocke

agocke commented Jul 21, 2022

Copy link
Copy Markdown
Member Author

Ugh looks like the installer tests aren't getting the live host now. I'm going to revert the original change until I can figure this out.

@agocke agocke closed this Jul 21, 2022
@agocke
agocke deleted the fix-runtime-pkg branch July 22, 2022 00:09
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants