Skip to content

Add a test that ensures we are using SubtleCrypto in WASM crypto tests - #72892

Merged
radical merged 6 commits into
dotnet:mainfrom
eerhardt:Fix69740
Jul 27, 2022
Merged

Add a test that ensures we are using SubtleCrypto in WASM crypto tests#72892
radical merged 6 commits into
dotnet:mainfrom
eerhardt:Fix69740

Conversation

@eerhardt

Copy link
Copy Markdown
Member

Fix #69740

@eerhardt
eerhardt requested review from bartonjs and radical July 26, 2022 23:22
@ghost ghost added the area-System.Security label Jul 26, 2022
@ghost ghost assigned eerhardt Jul 26, 2022
@eerhardt eerhardt added the arch-wasm WebAssembly architecture label Jul 26, 2022
@ghost

ghost commented Jul 26, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #69740

Author: eerhardt
Assignees: -
Labels:

area-System.Security

Milestone: -

@ghost

ghost commented Jul 26, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #69740

Author: eerhardt
Assignees: eerhardt
Labels:

arch-wasm, area-System.Security

Milestone: -

@bartonjs

Copy link
Copy Markdown
Member

The C# LGTM. The rest also LGTM, but in more of a nod-and-smile sort of way.

Comment thread src/libraries/System.Security.Cryptography/tests/wasm.helix.targets Outdated
Comment thread src/libraries/System.Security.Cryptography/tests/wasm.helix.targets
Comment thread src/libraries/System.Security.Cryptography/tests/wasm.helix.targets
@radical

radical commented Jul 27, 2022

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Jul 27, 2022

Copy link
Copy Markdown
Member

Wasm failures are known, and unrelated to this PR.

@radical

radical commented Jul 27, 2022

Copy link
Copy Markdown
Member

Failures are #72912, and #72916 .

@radical
radical merged commit 75cc8fa into dotnet:main Jul 27, 2022
@eerhardt
eerhardt deleted the Fix69740 branch July 27, 2022 12:37
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-System.Security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WASM error handling in SubtleCrypto through web worker

3 participants