Skip to content

[wasm-mt] Fix failing System.Xml tests on Browser with multi-threading enabled #75124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 7 commits into from
Sep 8, 2022
Merged

[wasm-mt] Fix failing System.Xml tests on Browser with multi-threading enabled #75124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3aa3420
Skip XmlSchemaSet test that gets stuck
simonrozsival Sep 6, 2022
d904a5e
Disable parallelization for XmlResolver tests to avoid deadlock
simonrozsival Sep 6, 2022
790f2dc
Skip failing XmlSystemPathResolverTests test
simonrozsival Sep 6, 2022
7cf0f58
Skip failing XmlSchemaValidatorApi test
simonrozsival Sep 6, 2022
0d66d1c
Update src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaVali…
simonrozsival Sep 6, 2022
250fd20
Disable failing tests instead of disabling parallelization
simonrozsival Sep 7, 2022
a54852a
Merge branch 'wasm-mt-fix-system-xml-xmlschemaset-tests-on' of github…
simonrozsival Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Private.Xml/tests/XmlReader/XmlResolver/XmlSystemPathResolverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ public static void TestResolveInvalidPaths()
[InlineData("http://notfound.invalid.corp.microsoft.com")]
[InlineData("ftp://host.invalid")]
[InlineData("notsupported://host.invalid")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/75129", TestPlatforms.Browser)]
public static void TestResolveInvalidPath(string invalidUri)
{
Assert.ThrowsAny<Exception>(() => XmlReader.Create(invalidUri));
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_Add_URL.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public void v3()

//-----------------------------------------------------------------------------------
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/75123", TestPlatforms.Browser)]
//[Variation(Desc = "v4 - ns = valid, URL = invalid")]
public void v4()
{
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaSet/TC_SchemaSet_XmlResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ public void v3()

//[Variation(Desc = "v4 - schema(Local)->schema(Local)", Priority = 1)]
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/75183", TestPlatforms.Browser)]
public void v4()
{
AppContext.SetSwitch("Switch.System.Xml.AllowDefaultResolver", true);
Expand All @@ -104,6 +105,7 @@ public void v4()

//[Variation(Desc = "v5 - schema(Local)->schema(Local)->schema(Local)", Priority = 1)]
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/75183", TestPlatforms.Browser)]
public void v5()
{
AppContext.SetSwitch("Switch.System.Xml.AllowDefaultResolver", true);
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Private.Xml/tests/XmlSchema/XmlSchemaValidatorApi/ValidateMisc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ public TCValidateAfterAddInvalidSchema(ITestOutputHelper output) : base(output)
[InlineData("SCHEMA", "schB1_a.xsd", 1, 3, 3)]
[InlineData("SCHEMA", "schM2_a.xsd", 1, 3, 3)]
[InlineData("SCHEMA", "schH2_a.xsd", 1, 3, 3)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/75132", TestPlatforms.Browser)]
public void AddValid_Import_Include_Redefine(string testDir, string testFile, int expCount, int expCountGT, int expCountGE)
{
string xsd = Path.Combine(path, testDir, testFile);
Expand Down