Skip to content

Adding check on R2RDump#78343

Merged
BrianBohe merged 5 commits intodotnet:mainfrom
BrianBohe:adding_check_on_r2rdump
Nov 16, 2022
Merged

Adding check on R2RDump#78343
BrianBohe merged 5 commits intodotnet:mainfrom
BrianBohe:adding_check_on_r2rdump

Conversation

@BrianBohe
Copy link
Copy Markdown
Member

Continuing with @cshung comment.

There shouldn't be variable debug information reported with an empty range. This PR adds the validation check to existent function validation taken place when dumping R2R images. Check is not applied by default, and a command line argument of R2RDump is added to run it. The argument is added to existent projects running tests with R2RDump.

@ghost ghost added the area-R2RDump-coreclr Ready-to-run image dump tool label Nov 14, 2022
@ghost ghost assigned BrianBohe Nov 14, 2022
@BrianBohe
Copy link
Copy Markdown
Member Author

Changes on src/tests/Common/CLRTest.CrossGen.targets will impact on pipelines. How can we test the changes on BasicTests and FrameworkTests?

@BrianBohe
Copy link
Copy Markdown
Member Author

I succeeded buildling BasicTests and FrameworkTests with .\src\tests\build.cmd dir .\readytorun\r2rdump\FrameworkTests\ dir .\readytorun\r2rdump\BasicTests\ but .\src\tests\run.cmd only run the former. Any idea of what can be happening?

@cshung cshung requested a review from trylek November 15, 2022 19:09
Copy link
Copy Markdown
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you!

@BrianBohe
Copy link
Copy Markdown
Member Author

All errors are known errors so I will continue and merge this pr

@BrianBohe BrianBohe merged commit 77fcc96 into dotnet:main Nov 16, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2022
@BrianBohe BrianBohe deleted the adding_check_on_r2rdump branch February 10, 2023 23:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-R2RDump-coreclr Ready-to-run image dump tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants