Prep for new diagnostic work and tests - #81571
Merged
AaronRobinsonMSFT merged 5 commits intoFeb 4, 2023
Merged
Conversation
|
Tagging subscribers to this area: @tommcdon Issue Details/cc @mikelle-rogers @dotnet/dotnet-diag
|
hoyosjs
approved these changes
Feb 2, 2023
AaronRobinsonMSFT
marked this pull request as draft
February 3, 2023 16:15
AaronRobinsonMSFT
changed the title
Instantiated MethodDesc. Renamed ambiguous method and updated some logging.
Member
Author
AaronRobinsonMSFT
marked this pull request as ready for review
February 3, 2023 23:24
jkotas
reviewed
Feb 3, 2023
jkotas
reviewed
Feb 3, 2023
hoyosjs
reviewed
Feb 4, 2023
Properly initialize MethodTableBuilder for EnC.
jkotas
approved these changes
Feb 4, 2023
hoyosjs
approved these changes
Feb 4, 2023
AaronRobinsonMSFT
added a commit
to AaronRobinsonMSFT/runtime
that referenced
this pull request
Feb 6, 2023
Removes GC_TRIGGERS contract for functions that do not trigger a GC. The removed contract definition appears to be out of date. Fallout from dotnet#81571
AaronRobinsonMSFT
added a commit
that referenced
this pull request
Feb 7, 2023
Removes GC_TRIGGERS contract for functions that do not trigger a GC. The removed contract definition appears to be out of date. Fallout from #81571
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is preparation for work in the diagnostics space.
Some tests were failing due to asserts when running against
a DBG/CHK runtime and those asserts have been addressed.
Move the EnC flag from the
InstantiatedMethodDescto theMethodDescand update code accordingly./cc @mikelle-rogers @dotnet/dotnet-diag