Skip to content

Fill missing @mention data in area-owners.json - #82228

Merged
marek-safar merged 1 commit into
dotnet:mainfrom
marek-safar:fabricbot
Feb 16, 2023
Merged

Fill missing @mention data in area-owners.json#82228
marek-safar merged 1 commit into
dotnet:mainfrom
marek-safar:fabricbot

Conversation

@marek-safar

Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost added the area-Meta label Feb 16, 2023
@ghost ghost assigned marek-safar Feb 16, 2023
@ghost

ghost commented Feb 16, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: marek-safar
Assignees: -
Labels:

area-Meta

Milestone: -

@marek-safar
marek-safar merged commit d43a9b2 into dotnet:main Feb 16, 2023
@marek-safar
marek-safar deleted the fabricbot branch February 16, 2023 12:59
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2023
@jeffhandley

Copy link
Copy Markdown
Member

While doing some area owner maintenance, I noticed this PR had gotten merged last month. This change doesn't actually have any effect. (Sorry this data management is so messy.)

The area-owners.json file only drives https://issuesof.net and its queries for area owners, architectures, and operating systems. It doesn't drive mentions/notifications--that's controlled through fabricbot.json.

Was the intent of this change to get the included folks mentioned upon labeling of linkable-framework or size-reduction? If so, the only change that looks like is needed is to add @marek-safar to the mentions of linkable-framework in fabricbot.json.

https://github.com/dotnet/runtime/blob/eefaa5a/.github/fabricbot.json#L930-L939

I'm making a bunch of other updates to area-owners.md, area-owners.json, and fabricbot.config; I can add that change into what I'm doing now (and remove the superfluous data added into area-owners.json).

@akoeplinger

Copy link
Copy Markdown
Member

I'm making a bunch of other updates to area-owners.md, area-owners.json, and fabricbot.config; I can add that change into what I'm doing now (and remove the superfluous data added into area-owners.json).

Thanks, yes please do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants