SPMI: Include example diffs in markdown summary#82364
Merged
Merged
Conversation
This adds up to 3 improvement and 3 regression example diffs to the markdown summary for each collection. The examples are picked to be the highest percentage wise improvements and regressions with a limit on the total size of the diff to avoid too much text in the diffs.
ghost
assigned
Member
Author
|
Unfortunately AzDO does not render the diffs with syntax highlighting in the Extensions tab: https://dev.azure.com/dnceng-public/public/_build/results?buildId=177452&view=ms.vss-build-web.run-extensions-tab |
am11
reviewed
Feb 19, 2023
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
…nto spmi-example-diffs
This reverts commit f30ceca.
Member
Author
Doing this in superpmi_diffs_summarize.py was manageable and saves us from having to pass through some --ci flag to superpmi.py. This is the example of the diffs page. A screenshot: PTAL @dotnet/jit-contrib |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds up to 3 improvement and 3 regression example diffs to the
markdown summary for each collection. The examples are picked to be the
highest percentage wise improvements and regressions with a limit on the
total size of the diff to avoid too much text in the diffs.