JIT: fix finally target flags after some flow graph updates - #82623
Merged
Conversation
In particular those done by profile instrumentation. Fixes dotnet#82275.
Member
Author
|
@BruceForstall PTAL May not catch all cases but presumably we're ok with existing edits and these are new cases arising from instrumentation. Am sorely tempted to just remove the need for this flag. |
BruceForstall
approved these changes
Feb 24, 2023
BruceForstall
left a comment
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Am sorely tempted to just remove the need for this flag.
That would be nice.
5 tasks
Member
Author
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular those done by profile instrumentation.
Fixes #82275.