Skip to content

[Mono] Enable runtime tests running on arm64 with mini JIT#82814

Merged
fanyang-mono merged 4 commits into
dotnet:mainfrom
fanyang-mono:enable_arm64_runtime_tests
Mar 3, 2023
Merged

[Mono] Enable runtime tests running on arm64 with mini JIT#82814
fanyang-mono merged 4 commits into
dotnet:mainfrom
fanyang-mono:enable_arm64_runtime_tests

Conversation

@fanyang-mono
Copy link
Copy Markdown
Member

@fanyang-mono fanyang-mono commented Mar 1, 2023

No description provided.

@ghost
Copy link
Copy Markdown

ghost commented Mar 1, 2023

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned fanyang-mono Mar 1, 2023
@build-analysis build-analysis Bot mentioned this pull request Mar 1, 2023
Closed
This was referenced Mar 1, 2023
Closed
Closed
Closed
Closed
SamMonoRT
SamMonoRT reviewed Mar 1, 2023
View reviewed changes
Comment thread src/tests/issues.targets Outdated
@SamMonoRT
Copy link
Copy Markdown
Member

SamMonoRT commented Mar 1, 2023

/cc @steveisok - this is a new lane being stood up to cover newer intrinsic work we are doing for JIT. Not sure if this is something we need to run by anyone and determine what loop it runs in?

@steveisok
Copy link
Copy Markdown
Member

steveisok commented Mar 1, 2023

/cc @steveisok - this is a new lane being stood up to cover newer intrinsic work we are doing for JIT. Not sure if this is something we need to run by anyone and determine what loop it runs in?

I don't think there are any restrictions if it runs like the others.

This was referenced Mar 1, 2023
Open
Closed
@fanyang-mono
Copy link
Copy Markdown
Member Author

fanyang-mono commented Mar 3, 2023

The new lane added by this PR runtime (Build linux-arm64 Release AllSubsets_Mono_Minijit_RuntimeTests minijit) has passed the testing.

@fanyang-mono fanyang-mono requested a review from steveisok March 3, 2023 00:47
@build-analysis build-analysis Bot mentioned this pull request Mar 3, 2023
Closed
5 tasks
@fanyang-mono
Copy link
Copy Markdown
Member Author

fanyang-mono commented Mar 3, 2023

CI failures are not related to the change in this PR.

@fanyang-mono fanyang-mono merged commit db084d9 into dotnet:main Mar 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SamMonoRT SamMonoRT SamMonoRT left review comments

@steveisok steveisok Awaiting requested review from steveisok

+2 more reviewers

@jandupej jandupej jandupej approved these changes

@LeVladIonescu LeVladIonescu LeVladIonescu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fanyang-mono fanyang-mono

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fanyang-mono @SamMonoRT @steveisok @jandupej @LeVladIonescu