Skip to content

[Arm64] Update execution characteristics for crc32b, crc32h, facge, facgt #8500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echesakov merged 4 commits into from
Feb 4, 2020
+39 −3
Merged

[Arm64] Update execution characteristics for crc32b, crc32h, facge, facgt #8500

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9aa4f22
Add execution characteristics for Crc32 instructions in emitarm64.cpp
echesakov Jan 31, 2020
23a8cbf
Update execution characteristics for DV_3B instructions in emitarm64.cpp
echesakov Jan 31, 2020
852603a
Add execution characteristics for DV_3D instructions in emitarm64.cpp
echesakov Jan 31, 2020
e6c518d
Update comment in emitIns_R_R_R in emitarm64.cpp
echesakov Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 39 additions & 3 deletions src/coreclr/src/jit/emitarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5268,8 +5268,8 @@ void emitter::emitIns_R_R_R(
}
else
{
assert(insOptsNone(opt));
// Scalar operation
assert(insOptsNone(opt));
assert(size == EA_8BYTE); // Only Int64/UInt64 supported
fmt = IF_DV_3E;
}
Expand Down Expand Up @@ -12378,6 +12378,22 @@ emitter::insExecutionCharacteristics emitter::getInsExecutionCharacteristics(ins
result.insLatency = PERFSCORE_LATENCY_1C;
break;

case INS_crc32b:
case INS_crc32h:
case INS_crc32cb:
case INS_crc32ch:
case INS_crc32x:
case INS_crc32cx:
result.insThroughput = PERFSCORE_THROUGHPUT_2X;
result.insLatency = PERFSCORE_LATENCY_2C;
break;

case INS_crc32w:
case INS_crc32cw:
result.insThroughput = PERFSCORE_THROUGHPUT_2X;
result.insLatency = PERFSCORE_LATENCY_1C;
break;

default:
// all other instructions
perfScoreUnhandledInstruction(id, &result);
Expand Down Expand Up @@ -12763,13 +12779,24 @@ emitter::insExecutionCharacteristics emitter::getInsExecutionCharacteristics(ins
result.insLatency = PERFSCORE_LATENCY_4C;
break;

case INS_facge:
case INS_facgt:
case INS_fcmeq:
case INS_fcmge:
case INS_fcmgt:
case INS_fcmle:
case INS_fcmlt:
result.insThroughput = PERFSCORE_THROUGHPUT_2X;
result.insLatency = PERFSCORE_LATENCY_2C;
if (id->idOpSize() == EA_16BYTE)
{
// Q-form
result.insThroughput = PERFSCORE_THROUGHPUT_1C;
result.insLatency = PERFSCORE_LATENCY_2C;
}
else
{
result.insThroughput = PERFSCORE_THROUGHPUT_2X;
result.insLatency = PERFSCORE_LATENCY_2C;
}
break;

case INS_fdiv:
Expand Down Expand Up @@ -12820,6 +12847,15 @@ emitter::insExecutionCharacteristics emitter::getInsExecutionCharacteristics(ins
result.insLatency = PERFSCORE_LATENCY_4C;
break;

case INS_facge:
case INS_facgt:
case INS_fcmeq:
case INS_fcmge:
case INS_fcmgt:
result.insThroughput = PERFSCORE_THROUGHPUT_2X;
result.insLatency = PERFSCORE_LATENCY_2C;
break;

case INS_fdiv:
if (id->idOpSize() == EA_8BYTE)
{
Expand Down