Skip to content

Re-enable disabled BigInteger tests. #87640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 1 commit into from
Jun 15, 2023
Merged

Re-enable disabled BigInteger tests. #87640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,7 +1383,6 @@ public async Task JsonIgnoreAttribute_UnsupportedCollection()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/63802", TargetFrameworkMonikers.NetFramework)]
public async Task JsonIgnoreAttribute_UnsupportedBigInteger()
{
string json = @"{""MyBigInteger"":1}";
Expand Down
1 change: 0 additions & 1 deletion ...tem.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ public static async Task SupportsBoxedRootLevelValues()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/63802", TargetFrameworkMonikers.NetFramework)]
public static void Converters_AndTypeInfoCreator_NotRooted_WhenMetadataNotPresent()
{
RemoteExecutor.Invoke(
Expand Down
4 changes: 0 additions & 4 deletions ...on/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,10 @@ public override async Task ClassWithIgnoredAndPrivateMembers_DoesNotIncludeIgnor
[JsonSerializable(typeof(ClassWithNewSlotAttributedDecimalProperty))]
[JsonSerializable(typeof(ClassWithNewSlotDecimalProperty))]
[JsonSerializable(typeof(LargeStructWithValueAndReferenceTypes))]
#if !NETFRAMEWORK
[JsonSerializable(typeof(ClassWithUnsupportedBigInteger))]
[JsonSerializable(typeof(WrapperForClassWithUnsupportedBigInteger))]
[JsonSerializable(typeof(ClassWithIgnoredUnsupportedBigInteger))]
[JsonSerializable(typeof(WrapperForClassWithIgnoredUnsupportedBigInteger))]
#endif
[JsonSerializable(typeof(ClassWithThingsToIgnore))]
[JsonSerializable(typeof(ClassWithMixedPropertyAccessors_PropertyAttributes))]
[JsonSerializable(typeof(ClassWithPropertyPolicyConflictWhichThrows))]
Expand Down Expand Up @@ -557,12 +555,10 @@ public void PublicContextAndJsonSerializerOptions()
[JsonSerializable(typeof(ClassWithNewSlotAttributedDecimalProperty))]
[JsonSerializable(typeof(ClassWithNewSlotDecimalProperty))]
[JsonSerializable(typeof(LargeStructWithValueAndReferenceTypes))]
#if !NETFRAMEWORK
[JsonSerializable(typeof(ClassWithUnsupportedBigInteger))]
[JsonSerializable(typeof(WrapperForClassWithUnsupportedBigInteger))]
[JsonSerializable(typeof(ClassWithIgnoredUnsupportedBigInteger))]
[JsonSerializable(typeof(WrapperForClassWithIgnoredUnsupportedBigInteger))]
#endif
[JsonSerializable(typeof(ClassWithThingsToIgnore))]
[JsonSerializable(typeof(ClassWithMixedPropertyAccessors_PropertyAttributes))]
[JsonSerializable(typeof(ClassWithPropertyPolicyConflictWhichThrows))]
Expand Down
4 changes: 2 additions & 2 deletions ....Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ public void UsePrivates()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/63802", TargetFrameworkMonikers.NetFramework)]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] // Netfx lacks IsExternalInit class needed for records
public void Record()
{
// Compile the referenced assembly first.
Expand Down Expand Up @@ -428,7 +428,7 @@ public record AppRecord(int Id)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/63802", TargetFrameworkMonikers.NetFramework)]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] // Netfx lacks IsExternalInit class needed for records
public void RecordInExternalAssembly()
{
// Compile the referenced assembly first.
Expand Down