Skip to content

Enable IOPack, IOEnqueue, and IODequeue on Windows - #88894

Merged
eduardo-vp merged 22 commits into
dotnet:mainfrom
eduardo-vp:feature/add-threadpool-events
Aug 9, 2023
Merged

Enable IOPack, IOEnqueue, and IODequeue on Windows#88894
eduardo-vp merged 22 commits into
dotnet:mainfrom
eduardo-vp:feature/add-threadpool-events

Conversation

@eduardo-vp

@eduardo-vp eduardo-vp commented Jul 14, 2023

Copy link
Copy Markdown
Member

Fixes #87020

@eduardo-vp
eduardo-vp requested a review from LakshanF July 14, 2023 04:21
@ghost ghost assigned eduardo-vp Jul 14, 2023
@ghost

ghost commented Jul 14, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: eduardo-vp
Assignees: eduardo-vp
Labels:

area-System.Threading

Milestone: -

Comment thread src/tests/tracing/eventlistener/EventListenerThreadPool.cs Outdated
@kouvel

kouvel commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

The IOEnqueue and IODequeue events are currently also raised in the portable implementation for registered waits. An IOEnqueue event is raised when the wait is registered, and an IODequeue event is raised just before each wait completion is processed. Could raise those for the Windows thread pool implementation similarly too.

Comment thread src/tests/tracing/eventlistener/EventListenerThreadPool.cs Outdated
Comment thread src/tests/tracing/eventlistener/EventListenerThreadPool.cs Outdated
Comment thread src/libraries/System.Private.CoreLib/src/System/Threading/Overlapped.cs Outdated
@eduardo-vp
eduardo-vp marked this pull request as ready for review August 3, 2023 00:03

@LakshanF LakshanF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from the NativeAOT perspective. Thanks for doing this work!

Comment thread src/tests/tracing/eventlistener/EventListenerThreadPool.cs Outdated
Comment thread src/tests/tracing/eventlistener/EventListenerThreadPool.cs Outdated
Comment thread src/tests/tracing/eventlistener/EventListenerThreadPool.cs Outdated

@kouvel kouvel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM, thanks!

@eduardo-vp
eduardo-vp merged commit 41f58f6 into dotnet:main Aug 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable relevant thread pool events in Windows

3 participants