Remove etw --exclude-feature tests. - #89107
Merged
vitek-karas merged 1 commit intoJul 21, 2023
Merged
Conversation
`--exclude-feature` logic was removed. If there is no intent to support this with coreclr bcl then we won't worry about it either. While we do need UnityLinker to continue to handle mono class libraries for awhile longer, the `--exclude-feature` functionality is a niche thing we can drop now.
ghost
added
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue Details
While we do need UnityLinker to continue to handle mono class libraries for awhile longer, the
|
Contributor
Author
|
@marek-safar or @vitek-karas is this PR ok? |
vitek-karas
approved these changes
Jul 21, 2023
Member
|
Failures are unrelated. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--exclude-featurelogic was removed. If there is no intent to support this with coreclr bcl then we won't worry about it either.While we do need UnityLinker to continue to handle mono class libraries for awhile longer, the
--exclude-featurefunctionality is a niche thing we can drop now.