[NativeAOT] Upstream some changes to portable allocation helpers - #89269
Merged
Conversation
ghost
added
area-NativeAOT-coreclr
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThese allocation helpers have only been used by the downstream WASM target until recently, when we switched to using copies of them specialized for the shadow stack calling convention in dotnet/runtimelab#2320. Since then, a couple bug fixes and changes have been made that the thinking is it makes sense to bring back to the portable code (dotnet/runtimelab#2342, dotnet/runtimelab#2345), so that it can still serve as a useful reference.
|
SingleAccretion
marked this pull request as ready for review
July 20, 2023 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These allocation helpers have only been used by the downstream WASM target until recently, when we switched to using copies of them specialized for the shadow stack calling convention in dotnet/runtimelab#2320.
Since then, a couple bug fixes and changes have been made that the thinking is it makes sense to bring back to the portable code (dotnet/runtimelab#2342, dotnet/runtimelab#2345), so that it can still serve as a useful reference.