Fix System.Net.Http.Json tests in AOT - #89307
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFix #89195.
|
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Have we thought about how we are testing in AOT with JsonSerializerIsReflectionEnabledByDefault=false (which is the default for AOT)?
At some point we'd need to refactor the test suite so that reflection vs. non-reflection components are adequately segregated. The tests happen to work in AOT currently because this declaration ensures the right generic specializations are included with the app, so re-enabling reflection seemed like the simplest way to make tests green again. |
I have verified locally that enabling reflection makes the test pass in AOT.
Fix #89195.