Skip to content

Set BaseSize of interfaces to 0 - #89343

Merged
jkotas merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:basesize
Jul 22, 2023
Merged

Set BaseSize of interfaces to 0#89343
jkotas merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:basesize

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

We were computing these as the minimum object size. This number is meaningless because they don't get allocated on the GC heap. A zero compresses better in the dehydrated data format. Surprisingly saves like 0.1% on Hello World despite being such an insignificant thing.

Cc @dotnet/ilc-contrib

We were computing these as the minimum object size. This number is meaningless because they don't get allocated on the GC heap. A zero compresses better. Surprisingly saves like 0.1% on Hello World despite being such an insignificant thing.
@ghost

ghost commented Jul 22, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

We were computing these as the minimum object size. This number is meaningless because they don't get allocated on the GC heap. A zero compresses better in the dehydrated data format. Surprisingly saves like 0.1% on Hello World despite being such an insignificant thing.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@jkotas
jkotas merged commit a2ce877 into dotnet:main Jul 22, 2023
@MichalStrehovsky
MichalStrehovsky deleted the basesize branch July 22, 2023 21:29
@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants