Skip to content

[Blazor] Add basic ICU tests - #89771

Merged
ilonatommy merged 22 commits into
dotnet:mainfrom
ilonatommy:basic-icu-wbt-tests-89406
Aug 9, 2023
Merged

[Blazor] Add basic ICU tests#89771
ilonatommy merged 22 commits into
dotnet:mainfrom
ilonatommy:basic-icu-wbt-tests-89406

Conversation

@ilonatommy

@ilonatommy ilonatommy commented Aug 1, 2023

Copy link
Copy Markdown
Member

Fixes #89406.
First merge #89926, then this one.

  1. Unblock Blazor WBT ICU assets checks.
  2. Rename internal LoadAllICUData -> LoadFullICUData. "All" could mean "all data files" while we meant to say "data with full locales support".
  3. Fixing the problem of loading all ICU assets to runtime pack in Hybrid or Full icu mode (see ShouldFilterCandidate).

For a follow-up PR: #90018

@ilonatommy ilonatommy added this to the 8.0.0 milestone Aug 1, 2023
@ilonatommy
ilonatommy requested a review from maraf August 1, 2023 12:02
@ilonatommy ilonatommy self-assigned this Aug 1, 2023
@ghost

ghost commented Aug 1, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Unblock Blazor WBT ICU assets checks.
  2. Rename internal LoadAllICUData -> LoadFullICUData. "All" could mean "all data files" while it means "data with full locales support".
  3. Fixing the problem of loading all ICU assets to runtime pack in Hybrid or Full icu mode (see ShouldFilterCandidate).

For a follow-up PR:

  • fixing the problem with hashing when custom ICU file is used in Blazor.
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization, area-Build-mono

Milestone: 8.0.0

@ghost

ghost commented Aug 1, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Unblock Blazor WBT ICU assets checks.
  2. Rename internal LoadAllICUData -> LoadFullICUData. "All" could mean "all data files" while it means "data with full locales support".
  3. Fixing the problem of loading all ICU assets to runtime pack in Hybrid or Full icu mode (see ShouldFilterCandidate).

For a follow-up PR:

  • fixing the problem with hashing when custom ICU file is used in Blazor.
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization, area-Build-mono

Milestone: 8.0.0

@ilonatommy ilonatommy closed this Aug 2, 2023
@ilonatommy ilonatommy reopened this Aug 2, 2023

@radical radical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this needs a review after your other PR, that splits the tests, is merged.

Comment thread src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs Outdated
Comment thread src/mono/wasm/Wasm.Build.Tests/ProjectProviderBase.cs Outdated
Comment thread src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs Outdated
Comment thread src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs Outdated
@ilonatommy
ilonatommy requested a review from radical August 7, 2023 10:56
Comment thread src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs Outdated
@ilonatommy
ilonatommy requested a review from radical August 8, 2023 09:37
Comment thread src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs Outdated
Comment thread src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs Outdated
Comment thread src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs
Comment thread src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs
Comment thread src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs Outdated
Comment thread src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs Outdated
Comment thread src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs

@radical radical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 In a follow up we should expand the tests, and maybe try to re-use the ones we have for test-main.js . I will fix up our API to facilitate that.

@ilonatommy
ilonatommy merged commit 13c8230 into dotnet:main Aug 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm] icu build related improvements

2 participants