Skip to content

Add units to http.client.active_requests & http.client.open_connections #90020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noahfalk merged 1 commit into from
Aug 7, 2023
Merged

Add units to http.client.active_requests & http.client.open_connections #90020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Net.Http/src/System/Net/Http/Metrics/MetricsHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public MetricsHandler(HttpMessageHandler innerHandler, IMeterFactory? meterFacto
// Meter has a cache for the instruments it owns
_activeRequests = meter.CreateUpDownCounter<long>(
"http.client.active_requests",
unit: "{request}",
description: "Number of outbound HTTP requests that are currently active on the client.");
_requestsDuration = meter.CreateHistogram<double>(
"http.client.request.duration",
Expand Down
1 change: 1 addition & 0 deletions ...stem.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/SocketsHttpHandlerMetrics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ internal sealed class SocketsHttpHandlerMetrics(Meter meter)
{
public readonly UpDownCounter<long> OpenConnections = meter.CreateUpDownCounter<long>(
name: "http.client.open_connections",
unit: "{connection}",
description: "Number of outbound HTTP connections that are currently active or idle on the client.");

public readonly Histogram<double> ConnectionDuration = meter.CreateHistogram<double>(
Expand Down