Switch DateTimeKind from Unspecified to Local

[Maximys]

Fix #30128

[ghost]

Tagging subscribers to this area: @dotnet/area-system-management
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fix #30128

Author:	Maximys
Assignees:	-
Labels:	area-System.Management
Milestone:	-

[Maximys]

@ericstj, could you look to current PR and failed test System.Management.Tests.ManagementDateTimeConverterTests.DateTime_MinValue_RoundTrip?
If I correctly understand, .NET Framework 4.8 currently use DateTime(Int32, Int32, Int32, Int32, Int32, Int32, Int32) inside ToDateTime method.

[ericstj]

That test cannot expect the behavior to change on .NETFramework - since we don't build System.Management for .NETFramework here.

If I correctly understand, .NET Framework 4.8 currently use DateTime(Int32, Int32, Int32, Int32, Int32, Int32, Int32) inside ToDateTime method.

Yes, that's correct.

So you'd need to make this test expect different behavior on .NETFramework.

@tarekgh @dotnet/area-system-management do you see a problem with this bug being fixed here?

[tarekgh]

I expressed in my old comment #30128 (comment) that the behavior is not matching the docs which expect the fixed behavior. So, I am fine with the fix but I prefer filing a breaking change issue for this one https://github.com/dotnet/docs/issues/new?assignees=gewarren&labels=breaking-change%2CPri1%2Cdoc-idea&projects=&template=breaking-change.yml&title=%5BBreaking+change%5D%3A+.

So you'd need to make this test expect different behavior on .NETFramework.

Correct, the test is already failing and should be fixed to return different result on NETFX. https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-90149-merge-039e8e43d9964292b0/System.Management.Tests/1/console.7246bcff.log?helixlogtype=result

[IDisposable]

[Maximys]

@tarekgh , test for .NET Framework was skipped by the 59e5892 commit.
Breaking change issue is here

[tarekgh]

@Maximys thanks a lot for your response and opening the breaking change tracking. Would it make sense to not skip the test on the NETFX and instead validate the expected value there? you can use

runtime/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

Line 21 in 376e235

public static bool IsNetFramework => RuntimeInformation.FrameworkDescription.StartsWith(".NET Framework", StringComparison.OrdinalIgnoreCase);

to do this check.

[Maximys]

@tarekgh , I had fixed highlighted problem, but there are some unrelated test failures. Could you look please?

[tarekgh]

I tracked the failed test with #90521