[wasm][debugger]Evaluate a sum between an object and a string - #90175
Merged
Conversation
|
Tagging subscribers to this area: @thaystg |
radical
reviewed
Aug 8, 2023
Co-authored-by: Ankit Jain <radical@gmail.com>
radical
requested changes
Aug 10, 2023
| { | ||
| var id = pause_location["callFrames"][0]["callFrameId"].Value<string>(); | ||
| await EvaluateOnCallFrameAndCheck(id, | ||
| ("myList+\"asd\"", TString("System.Collections.Generic.List`1[System.Int32]asd")) |
Member
There was a problem hiding this comment.
- can we also test this for a type that has
ToString()overridden? - And test
object o = new() - And what happens in case of a value type?
- what would happen for
list l = null; l + "asd"?
What about these?:
- object/vt + object/vt?
- object/vt + non-string primitive type?
- Any other binary operators, what happens in those cases?
These don't need to be fixed in this PR, I'm just curious if they would work or if they will at least fail without crashing.
ghost
added
the
needs-author-action
Co-authored-by: Ankit Jain <radical@gmail.com>
ghost
removed
the
needs-author-action
radical
approved these changes
Aug 14, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66824